Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove unnecessary go patch version from go.mods #3

Closed
wants to merge 1 commit into from

Conversation

arjan-bal
Copy link
Owner

@arjan-bal arjan-bal commented Nov 12, 2024

The patch version got added when bumping the go major version from 1.21 to 1.22. Specifying the patch version is not necessary unless the dependencies specify a path version. This PR removes the patch version from all but one go.mod file.

Why

As mentioned in this thread, grpc-go being a library should not specify a patch version.

RELEASE NOTES: N/A

@arjan-bal arjan-bal force-pushed the remove-patch-version branch from 8338c5d to a47a96c Compare November 12, 2024 17:27
@arjan-bal arjan-bal changed the title Remove go patch version from go.mod deps: Remove unnecessary go patch version from go.mods Nov 12, 2024
@arjan-bal arjan-bal marked this pull request as draft November 12, 2024 17:38
@arjan-bal arjan-bal closed this Nov 13, 2024
@arjan-bal arjan-bal deleted the remove-patch-version branch November 13, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant