Use taskkill instead of .kill() on Windows
#11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution to arjunmehta#10 Inspired by nodejs/node#3675
Sync removes a race between the taskkill and the cmd.exe exiting anyway. spawn is preferable to exec otherwise we're adding more cmd's in to the mix, which just seems unnecessary.
|
@efokschaner Looks good. Appreciate the contribution. Thanks! |
|
Superseded by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10
I've tested on my own windows machine and it has the intended behaviour of killing the tree of processes spawned indirectly through the CMD.