Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create comment_PR.yml #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Create comment_PR.yml #19

wants to merge 4 commits into from

Conversation

arjunsavel
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Check out this message!
This is a line break in the message
[] here is a box to fill out

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Before a PR is accepted, it must meet the following criteria:
[ ] Is the necessary information provided?
[ ] Does the PR have a complete description? Does it explain what the PR is attempting to do/fix, does it explain how it does this?
[ ] Is there an explanation of why this PR is needed?
[ ] Please use the following PR template: https://github.com/tardis-sn/tardis/blob/master/.github/PULL_REQUEST_TEMPLATE.md
[ ] Is this a duplicate PR?
[ ] If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
[ ] If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
[ ] Does it pass existing tests and are new tests provided if required?
[ ] The test coverage should not decrease, and for new features should be at or very close to 100%.
[ ] Is the code properly documented?
[ ] If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
[ ] Sphinx and docstrings in the code (in numpydoc format)
[ ] Does this conform to PEP 8 and the TARDIS style guidelines?
[ ] Does the PR fix the problem it describes?
[ ] Make sure it doesn’t e.g. just fix the problem for a specific case
[ ] Is this the best way of fixing the problem?
[ ] Is the code tidy?
[ ] No unnecessary print lines or code comments

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   25.74%   25.74%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits           61       61           
  Misses        176      176           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6284653...3bc40a3. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Before a PR is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Does the PR have a complete description? Does it explain what the PR is attempting to do/fix, does it explain how it does this?
  • Is there an explanation of why this PR is needed?
  • Please use the following PR template: https://github.com/tardis-sn/tardis/blob/master/.github/PULL_REQUEST_TEMPLATE.md
  • Is this a duplicate PR?
  • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
  • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
  • The test coverage should not decrease, and for new features should be at or very close to 100%.
  • Is the code properly documented?
  • If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
  • Sphinx and docstrings in the code (in numpydoc format)
  • Does this conform to PEP 8 and the TARDIS style guidelines?
  • Does the PR fix the problem it describes?
  • Make sure it doesn’t e.g. just fix the problem for a specific case
  • Is this the best way of fixing the problem?
  • Is the code tidy?
  • No unnecessary print lines or code comments

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Before a PR is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be at or very close to 100%.
  • Is the code properly documented?
    • If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
    • Sphinx and docstrings in the code (in numpydoc format)
  • Does this conform to PEP 8 and the TARDIS style guidelines?
  • Does the PR fix the problem it describes?
    • Make sure it doesn’t e.g. just fix the problem for a specific case
    • Is this the best way of fixing the problem?
  • Is the code tidy?
    • No unnecessary print lines or code comments

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Before a PR is accepted, it must meet the following criteria:

  • Is the necessary information provided?
    • Does the PR have a complete description? Does it explain what the PR is attempting to do/fix, does it explain how it does this?
    • Is there an explanation of why this PR is needed?
    • Please use the TARDIS PR template
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be at or very close to 100%.
  • Is the code properly documented?
    • If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
    • Sphinx and docstrings in the code (in numpydoc format)
  • Does this conform to PEP 8 and the TARDIS style guidelines?
  • Does the PR fix the problem it describes?
    • Make sure it doesn’t e.g. just fix the problem for a specific case
    • Is this the best way of fixing the problem?
  • Is the code tidy?
    • No unnecessary print lines or code comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants