-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* feat: add full width characters (#36) * perf: improve regex perf. by fixing catastrophic backtracking * test: polish tests for kana/kanji fns * feat: add full width characters * docs(readme.md): add link to the website containing demos * chore(release): 1.1.0-next.1 [skip ci] # [1.1.0-next.1](v1.0.0...v1.1.0-next.1) (2022-02-20) ### Features * add full width characters ([#36](#36)) ([13c162b](13c162b)) * docs: add recipes, contribution guide and TOCs (#37) * docs: add recipes, contribution guide and TOCs * chore(package.json): mark package as no side effects * docs(CONTRIBUTING.md): update size of release diagram * docs(readme.md): add types summary to TOC * docs(readme.md): add treeshake support badge * feat: allow importing package.json (#38) * chore(release): 1.1.0-next.2 [skip ci] # [1.1.0-next.2](v1.1.0-next.1...v1.1.0-next.2) (2022-02-21) ### Features * allow importing package.json ([#38](#38)) ([36198a9](36198a9)) * feat: add support for node >=12.22.0 and remove yarn from engine (#40) * chore(release): 1.1.0-next.3 [skip ci] # [1.1.0-next.3](v1.1.0-next.2...v1.1.0-next.3) (2022-02-21) ### Features * add support for node >=12.22.0 and remove yarn from engine ([#40](#40)) ([5b23783](5b23783)) * docs: add custom recipes to the demo page (#39) * docs: improve seo for docs website * chore(package.json): update keywords for npmjs * docs: add custom recipes to the demo page * docs: upgrade japanese-moji version * docs: make thresholds on demo page configurable (#41) * docs: improve anchor scrolling * docs: make thresholds on demo page configurable * docs: add analytics to the website (#42) * docs: add demo links to recipes.md (#43) Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
- Loading branch information
1 parent
bfd1b2a
commit 2d1c2c8
Showing
48 changed files
with
2,285 additions
and
967 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
# Contributing to Japanese Moji | ||
|
||
We are open to, and grateful for, any contributions made to this repository by you. Please review | ||
the following guide to keep track of our best practices | ||
|
||
**Table of Contents** | ||
|
||
- [Reporting Issues](#reporting-issues) | ||
- [Local setup](#local-setup) | ||
- [Building](#building) | ||
- [Testing and Linting](#testing-and-linting) | ||
- [New Features](#new-features) | ||
- [Submitting Changes](#submitting-changes) | ||
- [Making a Pull Request?](#making-a-pull-request) | ||
- [Commit Convention](#commit-convention) | ||
- [Release flow](#release-flow) | ||
|
||
## Reporting Issues | ||
|
||
Before opening an issue, please search the | ||
[issue tracker](https://github.com/arjunvegda/japanese-moji/issues) to make sure your issue hasn't | ||
already been reported. | ||
|
||
Please ask any general and implementation specific questions via | ||
[GitHub Discussion](https://github.com/arjunvegda/japanese-moji/discussions) | ||
|
||
## Local setup | ||
|
||
Visit the [Issue tracker](https://github.com/arjunvegda/japanese-moji/issues) to find a list of open | ||
issues that need attention. | ||
|
||
Fork, then clone the repo: | ||
|
||
``` | ||
git clone https://github.com/your-username/japanese-moji.git | ||
``` | ||
|
||
This repository uses Yarn v3 to manage this pacakage and documentations. You'll need to have Yarn | ||
v1.22 installed globally on your system first, as Yarn v3 depends on that being available first. | ||
Install dependencies with: | ||
|
||
``` | ||
yarn install | ||
# if you want to work on the documentation locally | ||
cd website && yarn install | ||
``` | ||
|
||
## Building | ||
|
||
Running the `build` task will create CommonJS, ESM, and a UMD build under `/dist` | ||
|
||
``` | ||
yarn build | ||
``` | ||
|
||
## Testing and Linting | ||
|
||
We use Jest to test our code. Therefore, yarn run test\* supports passing of all the arguments as | ||
Jest | ||
|
||
To run the tests: | ||
|
||
``` | ||
yarn test | ||
``` | ||
|
||
To continuously watch and run tests, run the following (supports all the arguments as jest): | ||
|
||
``` | ||
yarn test:watch | ||
``` | ||
|
||
To run tests with coverage, run the following (supports all the arguments as jest): | ||
|
||
``` | ||
yarn test:coverage | ||
``` | ||
|
||
To perform linting with `eslint`, run the following: | ||
|
||
``` | ||
yarn lint | ||
``` | ||
|
||
To perform linting with `eslint` and fix it, run the following: | ||
|
||
``` | ||
yarn lint:fix | ||
``` | ||
|
||
## New Features | ||
|
||
Please open an issue with a proposal for a new feature or refactoring before starting on the work. | ||
We don't want you to waste your efforts on a pull request that we won't want to accept. | ||
|
||
## Submitting Changes | ||
|
||
- Open a new issue in the [Issue tracker](https://github.com/arjunvegda/japanese-moji/issues) | ||
- Fork the repo | ||
- Create a new feature branch based off the `next` branch | ||
- Make sure all tests pass and that there are no linting errors | ||
- Submit a pull request, referencing any issues it addresses | ||
|
||
### Making a Pull Request? | ||
|
||
Pull requests require an approval from the maintainers of the project. | ||
|
||
#### Commit Convention | ||
|
||
We use | ||
[Angular's Conventional commit conventions](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type). | ||
Please use `category(scope or module): message` format in your commit message and use the following | ||
categories | ||
|
||
🚨 **All the changes under `./website/*` are categorized as `docs`, please use `docs` as category | ||
for your commit message in those cases** | ||
|
||
- **build**: Changes that affect the build system or external dependencies (example scopes: npm, | ||
yarn) | ||
- **ci**: Changes to our CI configuration files and scripts (examples: GitHub Actions) | ||
- **docs**: Documentation only changes | ||
- **feat**: A new feature | ||
- **fix**: A bug fix | ||
- **perf**: A code change that improves performance | ||
- **refactor**: A code change that neither fixes a bug nor adds a feature | ||
- **test**: Adding missing tests or correcting existing tests | ||
- **chore**: All changes other changes to the repository that do not fit into any of the above | ||
categories | ||
|
||
Please try to keep your pull request focused in scope and avoid including unrelated commits. | ||
|
||
After you have submitted your pull request, we'll try to get back to you as soon as possible. We may | ||
suggest some changes or improvements. | ||
|
||
Thank you for contributing 🙌! | ||
|
||
## Release flow | ||
|
||
We automatically release new versions of `next` branch to next channel on each merge. We also | ||
release new versions of `main` branch on the stable channel on each merge. | ||
|
||
<img src="./docs/release-flow.gif" width="400" alt="Release diagram"/> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2d1c2c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs: