Sparse poly eval #214
Merged
Sparse poly eval #214
+68
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
reviewed
Feb 8, 2021
Pratyush
reviewed
Feb 8, 2021
jon-chuang
force-pushed
the
sparse_poly_eval
branch
3 times, most recently
from
691d9a1
to
7340519
Compare
jon-chuang
force-pushed
the
sparse_poly_eval
branch
from
7340519
to
85e9128
Compare
Pratyush
reviewed
Feb 9, 2021
Comment on lines
66
to
69
| let total_bits = core::mem::size_of::<usize>() * 8; | ||
| let max_pow_2 = total_bits - self.degree().leading_zeros() as usize; | ||
|
|
||
| let mut pows_2 = Vec::<F>::with_capacity(max_pow_2); |
There was a problem hiding this comment.
This is computing log2(total_bits), right? You can replace it with let max_pow_2 = ark_std::log2(total_bits);.
There was a problem hiding this comment.
imo this should be a usize default function
There was a problem hiding this comment.
btw, I am uncomfortable with the current name, imo it ought to be named log2_then_ceil, or log2_of_next_pow_of_2 or something. I like the second name best.
|
Thanks for this! This LGTM once the comment is addressed |
|
Ok, it should be good to merge now |
Pratyush
reviewed
Feb 10, 2021
Pratyush
reviewed
Feb 11, 2021
Pratyush
reviewed
Feb 11, 2021
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Pratyush
reviewed
Feb 11, 2021
Pratyush
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #123
Results:
2.5x improvement.
New
Old
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer