-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast subgroup check as described in issue #308 #309
Fast subgroup check as described in issue #308 #309
Conversation
I found that I do not have write permission to the original branch... Can you do a |
Hi Simon, GitHub said "This branch is out-of-date with the base branch", in order to merge, you will need to update the source branch with the master branch. Often we recommend people to submit PR from a personal account and turn on "allow maintainers to edit", so we can perform the final cleanup including fmt without interactions with the PR submitter. This can save a lot of time since we can also add necessary CHANGELOG and make the changes directly. But if the PR comes from an organization account, usually this cannot be done. |
Hi. I did it in the PR #312. I close this PR |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer