Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast subgroup check as described in issue #308 #309

Closed

Conversation

simonmasson
Copy link
Contributor

@simonmasson simonmasson commented Aug 31, 2021

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen
Copy link
Member

I found that I do not have write permission to the original branch... Can you do a cargo fmt for passing the CI's check on style?

@weikengchen
Copy link
Member

Hi Simon, GitHub said "This branch is out-of-date with the base branch", in order to merge, you will need to update the source branch with the master branch.

Often we recommend people to submit PR from a personal account and turn on "allow maintainers to edit", so we can perform the final cleanup including fmt without interactions with the PR submitter. This can save a lot of time since we can also add necessary CHANGELOG and make the changes directly. But if the PR comes from an organization account, usually this cannot be done.

@simonmasson
Copy link
Contributor Author

simonmasson commented Sep 6, 2021

Hi. I did it in the PR #312. I close this PR

@simonmasson simonmasson closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants