Multilinear extension evaluation speedup #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protoben
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
weikengchen
approved these changes
Feb 15, 2023
mmagician
approved these changes
Feb 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
paberr
pushed a commit
to paberr/algebra
that referenced
this pull request
Feb 22, 2023
* Reduce # multiplications in dense ml extension eval * Reduce # multiplications in sparse ml extension eval * Eliminate extra vector allocation in precompute_eq * Add entry to changelog on mul reduction in eval functions
aleasims
pushed a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
* Reduce # multiplications in dense ml extension eval * Reduce # multiplications in sparse ml extension eval * Eliminate extra vector allocation in precompute_eq * Add entry to changelog on mul reduction in eval functions
aleasims
added a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
This reverts commit 82837b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change reduces the number of field multiplications performed in
DenseMultilinearExtension::evaluateandSparseMultilinearExtension::evaluate(actually, infix_variablesandprecompute_eq, respectively) by factoring.This results in a speedup in the polynomial-evaluation benchmarks over master (28-37% and 23-27%, respectively, on my machine).
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
dense::tests::evaluate_at_a_point,sparse::tests::evaluate, andsparse::tests::evaluate_edge_cases).Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer