Change generator of ark-curve25519 #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same generator of curve25519-dalek for inter-operability.
mmaker
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
|
Could you add a CHANGELOG entry please, this is a breaking change |
|
done 🫡 |
Pratyush
requested changes
Jan 31, 2024
mmaker
force-pushed
the
mmaker-patch-2
branch
from
ae23d41 to
fad1e7c
Compare
Pratyush
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this test: https://github.com/arkworks-rs/nimue/blob/main/src/plugins/tests.rs#L43
I try to make compatible transcripts between arkworks and dalek. The reason it passes right now is that, at line 54, I negate the generator. It'd be nice if they both were compatible so that people can use transcripts interchangeably between the two libraries