Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Array Deserialization Panic #837

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Fix Array Deserialization Panic #837

merged 8 commits into from
Jun 19, 2024

Conversation

ggwpez
Copy link
Contributor

@ggwpez ggwpez commented Jun 19, 2024 •
edited
Loading

Description

Use ArrayVec - as suggested here - to remove an unwrap in the decoding of arrays.

closes: #834

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

ggwpez added 2 commits June 19, 2024 17:16
@ggwpez
Fix Array Deserialization Panic
ee3d528 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Amend CHANGELOG
002a0cb 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@burdges
Copy link
Contributor

burdges commented Jun 19, 2024

Just use arrayvec here, my code stupidly had a memopry leak if T allocates. #834 (comment)

ggwpez
ggwpez commented Jun 19, 2024
View reviewed changes
serialize/src/lib.rs Outdated Show resolved Hide resolved
ggwpez added 3 commits June 19, 2024 17:34
@ggwpez
Use ArrayVec instead of unsafe
2ad2d84 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Unrelated fmt
fad19c8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge branch 'master' into master
443495a
@ggwpez ggwpez marked this pull request as ready for review June 19, 2024 15:36
@ggwpez ggwpez requested review from a team as code owners June 19, 2024 15:36
@ggwpez ggwpez requested review from z-tech, mmagician and weikengchen and removed request for a team June 19, 2024 15:36
mmagician
mmagician reviewed Jun 19, 2024
View reviewed changes
serialize/src/impls.rs Outdated Show resolved Hide resolved
ggwpez and others added 3 commits June 19, 2024 18:10
@ggwpez
Defensive programming not needed
5fd19eb 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
.ok().unwrap()
85cfcc8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@Pratyush
Merge branch 'master' into master
91e1b85
@mmagician mmagician added this pull request to the merge queue Jun 19, 2024
Merged via the queue into arkworks-rs:master with commit 79a5fe3 Jun 19, 2024
37 checks passed
This was referenced Jun 23, 2024
Closed
Open
@davxy davxy mentioned this pull request Jul 8, 2024
Merged
@xlc xlc mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burdges burdges burdges left review comments

@mmagician mmagician mmagician approved these changes

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization of array can panic
4 participants
@ggwpez @burdges @Pratyush @mmagician