fix: Make subscription_details.metadata optional #443
Conversation
It appears that metadata can be null from the stripe api
benbrandt
force-pushed
the
subscription-details-metadata
branch
from
a4a8c1d to
563e39c
Compare
|
@arlyon can we get this merged timely and can we have a release containing this fix on crates.io? Thanks! |
|
CI running now I'll check back in 30 mins |
|
@arlyon it seems this will fail because the generated code doesn't match. I assumed this might be the case, but I'm not sure where the code would be to make this generate an Option based on the nullable field |
|
I am going to sort this out in the codegen for you I have a free 30 mins now |
| @@ -1234,7 +1234,11 @@ pub fn gen_field_rust_type<T: Borrow<Schema>>( | |||
| } | |||
| if field_name == "metadata" { | |||
| state.use_params.insert("Metadata"); | |||
| return "Metadata".into(); | |||
| return if !required || is_nullable { | |||
There was a problem hiding this comment.
@arlyon after doing a quick search, this seemed the likely culprit, but feel free to do something else if this isn't the way to fix it.
There was a problem hiding this comment.
I have a PR that also applies to EventData also, closing in favour of that one :)
|
Closing for #444 |
|
Released as 0.25.1 Technically a breaking change but this library has pretty lax opinions on breaking changes that come as a result of openapi changes, since a breaking change in stripe is a breaking change for code that relies on stripe. Now to investigate why releases / changelogs are broken ... always something broken 😂 |
|
Thanks a lot for the timely fix! |
Summary
Looking at the OpenAPI spec, this field is
nullable, and therefore should be anOption. All of our invoice webhook events are failing because the webhook events hasOn both the latest and last API version of stripe.
Checklist
cargo make fmt