Fix panic in tokio client when encountering unsupported StatusCode #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http_types::StatusCode doesn't support all status codes that http::StatusCode supports, but still implements From<http::StatusCode>, just with an `unwrap`. This is unfortunate because it can cause the client to panic upon responses that contain status codes not explicitly supported by http_types.
|
I really don't think there's anything I can/should do about the |
|
I am not sure why the codegen would be causing an issue. I will merge this and solve that separately, TY. Do you know what status code was failing for you? |
|
Sadly no, because the panic message didn't contain that information. But there's some mention of cloudflare status codes here: http-rs/http-types#507 |
|
Seems like silly behaviour on both sides. I am ok using this as a workaround. Release 0.25.2 is publishing now :) Edit: live! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a panic in production because of a well known issue in
http_typeswhere StatusCode conversion can panic:A proper fix probably involves switching away from
http_typesentirely, but I interrupted my initial attempt because that requires changes all over the code base (replacingRequest,Method,UrlandBodytypes).Therefore I'm submitting this quick fix which just avoids the code path with the
unwrap.Checklist
cargo make fmt