Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TestClock operations #579

Merged

Conversation

augustoccesar
Copy link
Contributor

Summary

This adds support to the following TestClock operations:

Closes #574

Checklist

@augustoccesar
Copy link
Contributor Author

Just saw that this is now correctly generated on the next branch. So not sure if we want to go ahead with this or if is better to wait for it to reach master.

@arlyon let me know if you think is better to close this one and wait.

@arlyon
Copy link
Owner

arlyon commented Jul 29, 2024

Hey! Thanks for taking the time. If you are willing to go ahead and test the next branch I would be very interested in feedback. It will end up as '1.0' eventually and I would like to cut an alpha soon but early testers are appreciated. However, happy to merge this as well since I think stabilising will take a while.

Going to set time aside to review this soon

Have a lovely day

@augustoccesar
Copy link
Contributor Author

Will definitely take the next branch for a spin! I started to take a look into it and play around and is feeling very nice.
But yeah, since that will take a bit to land on main, makes sense to go ahead with this one so that it is available on the current version 👍

@arlyon
Copy link
Owner

arlyon commented Jul 31, 2024

Approved please rebase for the linting items and I'll merge (just to be safe)

@augustoccesar augustoccesar force-pushed the feat/add-support-to-test-clock-operations branch from 53aa1b6 to d792798 Compare July 31, 2024 18:54
@arlyon arlyon merged commit e14308d into arlyon:master Jul 31, 2024
16 of 17 checks passed
@arlyon
Copy link
Owner

arlyon commented Jul 31, 2024

Hero! Thanks! 🎉

@arlyon
Copy link
Owner

arlyon commented Jul 31, 2024

🎉 This PR is included in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing methods for dealing with TestClocks
2 participants