Fix renewing of cancelled jobs. #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug in redis script caused cancelled job to be returned to the queue.
JamesMurkin
approved these changes
Nov 27, 2019
svc-gh-ghzonetrans-p
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Move PulsarConfig into common/config (#217) (#3907) * ARMADA-2848 Move PulsarConfig into commonconfig * Update test name TestValidateHasJobSetID->Id * Revert unintended changes to yarn.lock file * fix import order Co-authored-by: Eleanor Pratt <Eleanor.Pratt@gresearch.co.uk> (cherry picked from commit 35cb59f) Signed-off-by: mustaily891 <mustafa.ilyas@gresearch.co.uk> * Adding ControlPlaneEventsTopic to pulsar config * Evolving ControlPlaneEvents message structure We've decided on a parent/wrapper message for the ControlPlaneEvents to avoid passing around ambiguous proto.Message slices in the Publisher and Ingester. * Setting maxAllowedMessageSize to correct value in relevant tests * Removing reason for uncordon requests to the executor service * Moving event creation time to parent Control Plane Event, modifying executor service rpcs to reflect the events being published, changed pulsar message keys to hard coded strings rather than proto name * Renaming UpdateExecutorSettings rpc to UpsertExecutorSettings * Removing message keys from ControlPlaneEvent messages, reverting method name changes * Renaming LimitEventSequencesByteSize * Adding executor cordoning functionality to armadactl * Renaming ControlPlaneEvent to Event * Simplifying executor cordoning code * More sane checks on UpsertExecutorSettings rpc, better error messages * Typo * Updated command descriptions for executor cordoning and uncordoning * Separating executor service args from controlplaneevents * Executor Service #2 (#254) * Generalising common ingestion pipeline * Removing unused config * Amending comments and variable names in common ingestion pipeline to be more event agnostic * Returning to original metric name, denoting ingested event type via labal rather than metric name * Import ordering * Generalising pulsar publisher * Executor Service #3 (#255) * Modifying SchedulerIngester to ingest control plane events, creating executor settings table and associated plumbing * Simplifying dbops merge for controlplanevents * Moving DBOperation scoping into schedulerdb * Adding GetOperation method to DBOperation, determining locking using this * Executor Service #4 (#257) * Implementing cluster cordoning in scheduler * Filter executors from previous filter result * Adding default value for queue label when publishing controlplaneevent metrics --------- Signed-off-by: mustaily891 <mustafa.ilyas@gresearch.co.uk> Co-authored-by: Eleanor Pratt <Eleanor.Pratt@gresearch.co.uk>
MustafaI
added a commit
that referenced
this pull request
Oct 17, 2024
* Move PulsarConfig into common/config (#217) (#3907) * ARMADA-2848 Move PulsarConfig into commonconfig * Update test name TestValidateHasJobSetID->Id * Revert unintended changes to yarn.lock file * fix import order (cherry picked from commit 35cb59f) * Adding ControlPlaneEventsTopic to pulsar config * Evolving ControlPlaneEvents message structure We've decided on a parent/wrapper message for the ControlPlaneEvents to avoid passing around ambiguous proto.Message slices in the Publisher and Ingester. * Setting maxAllowedMessageSize to correct value in relevant tests * Removing reason for uncordon requests to the executor service * Moving event creation time to parent Control Plane Event, modifying executor service rpcs to reflect the events being published, changed pulsar message keys to hard coded strings rather than proto name * Renaming UpdateExecutorSettings rpc to UpsertExecutorSettings * Removing message keys from ControlPlaneEvent messages, reverting method name changes * Renaming LimitEventSequencesByteSize * Adding executor cordoning functionality to armadactl * Renaming ControlPlaneEvent to Event * Simplifying executor cordoning code * More sane checks on UpsertExecutorSettings rpc, better error messages * Typo * Updated command descriptions for executor cordoning and uncordoning * Separating executor service args from controlplaneevents * Executor Service #2 (#254) * Generalising common ingestion pipeline * Removing unused config * Amending comments and variable names in common ingestion pipeline to be more event agnostic * Returning to original metric name, denoting ingested event type via labal rather than metric name * Import ordering * Generalising pulsar publisher * Executor Service #3 (#255) * Modifying SchedulerIngester to ingest control plane events, creating executor settings table and associated plumbing * Simplifying dbops merge for controlplanevents * Moving DBOperation scoping into schedulerdb * Adding GetOperation method to DBOperation, determining locking using this * Executor Service #4 (#257) * Implementing cluster cordoning in scheduler * Filter executors from previous filter result * Adding default value for queue label when publishing controlplaneevent metrics --------- Signed-off-by: mustaily891 <mustafa.ilyas@gresearch.co.uk> Co-authored-by: Mustafa Ilyas <Mustafa.Ilyas@gresearch.co.uk> Co-authored-by: Eleanor Pratt <Eleanor.Pratt@gresearch.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in redis script caused cancelled job to be returned to the queue.