Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report jobs done once their state has been reported #899

Merged
merged 1 commit into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. Only report jobs done once their state has been reported

    Normally the state gets reported instantly so this is already true 99% of the time.
    
    However if reporting the state goes wrong, we shouldn't report the job as done
     - Otherwise the server will tell the executor to kill the pod when it tries to maintain the lease
    
    In all other places we make sure the JobEvent has been reported first before reporting done, so we should do that here too
    
    This will only really impact edge cases and most of the time this will already be true
    JamesMurkin committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7d03d5e View commit details
    Browse the repository at this point in the history