Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix pr announce for all contributors #7081

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

EvilOlaf
Copy link
Member

The earlier attempt seem to limit announces to repository members for some reason.
This attempt limits to the repo only, therefore forks should not be affected.
Not sure if it works, but there is only one way to find out.

The earlier attempt seem to limit announces to repository members for some reason.
This attempt limits to the repo only, therefore forks should not be affected.
Not sure if it works, but there is only one way to find out.
@github-actions github-actions bot added size/small PR with less then 50 lines GitHub Actions GitHub Actions code labels Aug 13, 2024
Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I was just about to file a bug/issue.
Although as far as my GH Actions knowledge goes, using the ${{ ... }} is best practice, so I'd not remove that.

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Aug 13, 2024

@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Aug 13, 2024

Hm gh docs don't mention this: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-only-run-job-for-specific-repository

Looks like it 😄 You can optionally omit the brackets in some cases, as explained in this article:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/expressions

I guess it's also personal taste. For me, instead of having to think "do I need this here or can I omit it", it's easier to just always use it :)
You can do it as you prefer, it should work either way.

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Aug 13, 2024

I see. Well I don't really care nor do I have much knowledge about actions, basics only. Feel free to enhance formatting :)

Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine in this case, my linter doesn't show any warning :) And I also don't care enough in this case 😂

@EvilOlaf EvilOlaf merged commit da899b2 into main Aug 13, 2024
9 checks passed
@EvilOlaf EvilOlaf deleted the EvilOlaf-patch-1 branch August 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions GitHub Actions code size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants