Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: disable armbian repository while generating rootfs cache #7123

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Framework: disable armbian repository while generating rootfs cache #7123

merged 1 commit into from
Aug 22, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 22, 2024 •
edited
Loading

Description

Rootfs cache was designed to contain clean package base without any Armbian packages. Since we are providing our own base-files (also via repository) cache file is upgraded from, if repository is present. We don't want that.

This caused several problems: #7048 AR-2350 AR-2454

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Aug 22, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Aug 22, 2024
@igorpecovnik igorpecovnik force-pushed the disable-armbian-repo-rootfscache branch from 1652325 to 71a6a13 Compare August 22, 2024 14:36
@igorpecovnik igorpecovnik marked this pull request as ready for review August 22, 2024 14:48
@igorpecovnik igorpecovnik requested a review from a team as a code owner August 22, 2024 14:48
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 08 Milestone: Third quarter release Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Aug 22, 2024
@igorpecovnik igorpecovnik mentioned this pull request Aug 22, 2024
Closed
4 tasks
@igorpecovnik igorpecovnik merged commit 7129643 into main Aug 22, 2024
5 checks passed
@igorpecovnik igorpecovnik deleted the disable-armbian-repo-rootfscache branch August 22, 2024 14:53
@JohnTheCoolingFan
Copy link
Contributor

JohnTheCoolingFan commented Aug 22, 2024 •
edited
Loading

I'm still having the downgrade problem, on main, with cleared cache and output/debs dir: https://paste.armbian.com/itativijah

@igorpecovnik
Copy link
Member Author

I see. Something else is still a problem.

@igorpecovnik igorpecovnik mentioned this pull request Aug 23, 2024
Merged
6 tasks
rpardini added a commit to armsurvivors/armbian-build that referenced this pull request Sep 30, 2024
@rpardini
rootfs: don't use the Armbian repo when building rootfs from both GHA…
85c48c7 
… pipelines and CLI; fixes armbian#7123

- Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used
  - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts
    - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter
    - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect
- rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly
- also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc
rpardini added a commit to armsurvivors/armbian-build that referenced this pull request Sep 30, 2024
@rpardini
rootfs: don't use the Armbian repo when building rootfs from both GHA…
73a0c05 
… pipelines and CLI; fixes armbian#7123

- Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used
  - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts
    - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter
    - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect
- rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly
- also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc
- add change tracking calls before/after generic artifact config adapter for even more clarity
rpardini added a commit to armsurvivors/armbian-build that referenced this pull request Sep 30, 2024
@rpardini
rootfs: don't use the Armbian repo when building rootfs from both GHA…
529e7b8 
… pipelines and CLI; fixes armbian#7123

- Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used
  - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts
    - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter
    - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect
- rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly
- also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc
- add change tracking calls before/after generic artifact config adapter for even more clarity
rpardini added a commit to rpardini/armbian-build that referenced this pull request Sep 30, 2024
@rpardini
rootfs: don't use the Armbian repo when building rootfs from both GHA…
9822329 
… pipelines and CLI; fixes armbian#7123

- Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used
  - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts
    - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter
    - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect
- rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly
- also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc
- add change tracking calls before/after generic artifact config adapter for even more clarity
@rpardini rpardini mentioned this pull request Sep 30, 2024
Merged
igorpecovnik pushed a commit that referenced this pull request Sep 30, 2024
@rpardini @igorpecovnik
rootfs: don't use the Armbian repo when building rootfs from both GHA…
55b8718 
… pipelines and CLI; fixes #7123

- Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used
  - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts
    - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter
    - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect
- rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly
- also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc
- add change tracking calls before/after generic artifact config adapter for even more clarity
@rpardini rpardini mentioned this pull request Oct 15, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeepn adeepn adeepn approved these changes

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorpecovnik @JohnTheCoolingFan @adeepn