Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout on check wan address on motd #7297

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

SuperKali
Copy link
Member

@SuperKali SuperKali commented Sep 25, 2024

Description

Add a timeout on check the wan address

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • I self performed a test on my environment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

- Without this control it can cause a continuous loop until curl goes into timeout
@SuperKali SuperKali requested a review from a team as a code owner September 25, 2024 07:50
@github-actions github-actions bot added size/small PR with less then 50 lines BSP Board Support Packages labels Sep 25, 2024
@SuperKali SuperKali added 11 Milestone: Fourth quarter release Needs review Seeking for review Framework Framework components BSP Board Support Packages and removed BSP Board Support Packages labels Sep 25, 2024
@viraniac
Copy link
Collaborator

viraniac commented Sep 25, 2024

Personally I don't understand why there is a need to get public IP for a system and show it in motd. But assuming its needed by others, why not just use --connect-timeout option of curl and specify a timeout directly. That way there will be no need to ping anything first and hence there will be no need to hard code Google's dns server either

@SuperKali SuperKali changed the title Add network connectivity check with ping before fetching WAN address Add timeout on check wan address on motd Sep 25, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 25, 2024
@igorpecovnik igorpecovnik merged commit 5bd697b into armbian:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release BSP Board Support Packages Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

4 participants