Add ipv6 addresses if present and sort ips #7299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/small
SuperKali
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Great work! However, I suggest integrating the function for retrieving local IPv6 addresses directly into the get_ip_addresses function, rather than creating a separate one. As for obtaining the public IPv6 address, you can use the current approach of making a curl request to the site over IPv6.
|
I didn't get to it yet, I'll update the PR in the next days |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorting IP addresses and adding IPv6 addresses to sysinfo motd.
How Has This Been Tested?
Set IPv6 address on interface and run /etc/motd/30-armbian-sysinfo
Checklist:
Please delete options that are not relevant.