Improvements to the Configurator #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duanemay
commented
Jun 25, 2015
duanemay
commented
- Added PUT method to update device
- Improvements to the Configurator:
- Styling changes
- allow for loading devices from URL
- use window url to figure out base rather then localhost
- ability to edit existing device
- Improved the README
…hen not on localhost
…evices after changing bridge URL
|
|
||
| $scope.bridge = bridgeService.state; | ||
| $scope.device = {name: "", type: "switch", onUrl: "", offUrl: ""}; | ||
| $scope.vera = {base: "http://192.168.1.144:3480", id: 1}; |
There was a problem hiding this comment.
Yeah that was in the original code, unlike the bridgeURL we can't really make a smart guess on where Vera is. I do like that this shows the port Vera listens on, and that no slash or path is needed after this. Maybe this could be moved to the placeholder text though.
…took out the default value for the vera url
armzilla
added a commit
that referenced
this pull request
Jul 13, 2015
Improvements to the Configurator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.