Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow && + allow double ticks #49 #50 #57

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Allow && + allow double ticks #49 #50 #57

merged 4 commits into from
Nov 22, 2022

Conversation

margauxschmied
Copy link
Collaborator

@margauxschmied margauxschmied commented Nov 19, 2022 •
edited by arnaud-m
Loading

@margauxschmied margauxschmied self-assigned this Nov 19, 2022
FissoreD
FissoreD reviewed Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@FissoreD FissoreD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know if it is useful to have a lot of test which are essentially a copy of the tests for the ";" (maybe mr @arnaud-m would clear my doubt).
I think that they will all pass since your modifications doesn't change the "heart" of the grammar, it seems to me that you are "testing ANTLR". Correct me please if I am misunderstanding 😳 .
However, I think that more tests with both the ; and the && would be interesting ?
Have you tried some tests with an odd number of &, to see if it throws an error ?
(Sorry, I can't test it, since I'm not on my working laptop)

src/main/java/cryptator/CryptaOperator.java Outdated Show resolved Hide resolved
@margauxschmied margauxschmied changed the title Allow && #50 Allow && + allow double ticks #49 #50 Nov 19, 2022
@arnaud-m arnaud-m merged commit 946924c into main Nov 22, 2022
@arnaud-m arnaud-m deleted the Allow_&& branch November 22, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FissoreD FissoreD FissoreD left review comments

@arnaud-m arnaud-m arnaud-m left review comments

@Imp95 Imp95 Awaiting requested review from Imp95

@mpelleau mpelleau Awaiting requested review from mpelleau

Assignees

@margauxschmied margauxschmied

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow && for parsing multiple cryptarithms [FEATURE] Allow double ticks as number's delimeters
3 participants
@margauxschmied @arnaud-m @FissoreD