Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make setScreenName run in main thread. #751

Closed
wants to merge 1 commit into from

Conversation

sandfield-andy
Copy link

I've made changes to the setScreenName function to run in the main thread. This is needed to make it work for iOS.

@remisture
Copy link

Just curious, what is it that's not working on iOS? Screen name is apparently working for me - it appears in the Analytics dashboard, at least.

@karlbohlmark
Copy link

Whats the status here? Will this be merged? @soumak77

@soumak77
Copy link
Contributor

@sandfield-andy could you fix the merge conflicts so I can merge this PR?

soumak77 added a commit that referenced this pull request Aug 31, 2018
@soumak77
Copy link
Contributor

fixed via bce8acd

@soumak77 soumak77 closed this Aug 31, 2018
@JonSmart
Copy link
Contributor

@soumak77 will you be doing a new release version with this fix? 1.1.1?

@soumak77
Copy link
Contributor

@JonSmart sure, publishing now

@JonSmart
Copy link
Contributor

@soumak77 perfect. Thanks.

@newuser44
Copy link

Has this been pushed in?

@soumak77
Copy link
Contributor

@newuser44 yes, try version 1.1.4

@newuser44
Copy link

it seems to be pulling firebase 2.0.0 I know there is a way to pull a specific version.

@soumak77
Copy link
Contributor

2.0 should be fine too. 2.0 upgrades firebase SDK which you might want as well. See the CHANGELOG for more info.

If you want 1.1.4, run cordova plugin add cordova-plugin-firebase@1.1.4

@newuser44
Copy link

it looks like I have 1.1.4
The error I'm seeing is
ERROR: Unhandled Promise rejection: Analytics isn't initialised ; Zone: ; Task: setTimeout ; Value: Analytics isn't initialised

@soumak77
Copy link
Contributor

@newuser44 I believe #832 will fix your problem. If you are able to test that PR, we can get a new version published sooner

@newuser44
Copy link

Sorry, not really sure how I would test that seperate build. Are these problems solved in the 2.0 version?

@soumak77
Copy link
Contributor

@newuser44 the setScreenName running on the main thread is fixed, but we need #832 merged to fix the issue you're running into with analytics not being initialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants