Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor after_prepare hook #905

Merged
merged 2 commits into from
Oct 10, 2018
Merged

refactor after_prepare hook #905

merged 2 commits into from
Oct 10, 2018

Conversation

soumak77
Copy link
Contributor

@soumak77 soumak77 commented Oct 9, 2018

Move after_prepare hook outside of platforms tag in plugin.xml

fixes #897

@soumak77 soumak77 self-assigned this Oct 9, 2018
@soumak77 soumak77 requested a review from briantq October 9, 2018 16:05
scripts/lib/utilities.js Outdated Show resolved Hide resolved
@briantq
Copy link
Contributor

briantq commented Oct 10, 2018

@soumak77 Confirmed it does resolve the issue of copying the GoogleServices file on iOS. There was only question about one method but outside of answering that, I am ok merging this request.

@soumak77 soumak77 merged commit 52a0c4a into master Oct 10, 2018
@robertarnesson robertarnesson deleted the fix-after-prepare branch January 15, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid GOOGLE_APP_ID
2 participants