tighten rhs expression whitespace and indent #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rendering the right-hand expression of a keyword like `return` or an assignment, sometimes we would add a newline and indent. This PR avoids such extra indent/newlines by allowing partial expressions such as function calls to continue on the same line like so: ```nim let myvariable = functioncall( arg0, arg1, ... ) ``` This saves significant amounts of space as we avoid the extra indent that previously would apply to the arguments in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering the right-hand expression of a keyword like
returnor an assignment, sometimes we would add a newline and indent.This PR avoids such extra indent/newlines by allowing partial expressions such as function calls to continue on the same line like so:
This saves significant amounts of space as we avoid the extra indent that previously would apply to the arguments in this case.