Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configuration of InferredEncodings #102

Merged
merged 2 commits into from
Mar 31, 2022
Merged

add configuration of InferredEncodings #102

merged 2 commits into from
Mar 31, 2022

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Mar 30, 2022

Signed-off-by: Olivier Lamy olamy@apache.org

Short description of what this resolves:

Changes proposed in this pull request:

Fixes: #

@olamy
add configuration of InferredEncodings
27e9c9f 
Signed-off-by: Olivier Lamy <olamy@apache.org>
joakime
joakime reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test case?
What is this for?
Why not just use MimeTypes directly?

@olamy
add test
12d10aa 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Contributor Author

olamy commented Mar 30, 2022

No test case? What is this for? Why not just use MimeTypes directly?

test added.

TCK says

response.setContentType("text/html");
response.getCharacterEncoding() -> iso-8859-1

@olamy olamy requested a review from joakime March 31, 2022 12:24
@olamy olamy merged commit af15800 into master Mar 31, 2022
@olamy olamy deleted the inferredEncodings-setup branch March 31, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

Assignees

@joakime joakime

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @joakime