chore(junit5): ports tests from arquillian-junit-container #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test in CircleCI is to be expected as long as #310 is not fixed |
|
That's fantastic @bartoszmajsak |
lprimak
previously approved these changes
Feb 23, 2021
bartoszmajsak
requested changes
Feb 23, 2021
| public class JUnitIntegrationTestCase extends JUnitTestBaseClass { | ||
|
|
||
| @Test | ||
| public void should_execute_extensions() throws Exception { |
There was a problem hiding this comment.
As much as I'm in favor of underscores in the test method names I think we should play a bit conservative here and stick to the convention we have across the project. OR... rename everything to underscores - your call ;)
There was a problem hiding this comment.
I'm not in favor either and will stick to the conventions - names are copies of the junit4 tests.
I will rename all test methods to camelCase.
There was a problem hiding this comment.
If that's the case I will review the rest and take care of boy scouting!
.../test/java/org/jboss/arquillian/junit5/container/JUnitJupiterDeploymentAppenderTestCase.java
Outdated
Show resolved
Hide resolved
.../container/src/test/java/org/jboss/arquillian/junit5/container/JUnitIntegrationTestCase.java
Outdated
Show resolved
Hide resolved
...iner/src/test/java/org/jboss/arquillian/junit5/container/JUnitJupiterTestRunnerTestCase.java
Outdated
Show resolved
Hide resolved
junit5/container/src/test/java/org/jboss/arquillian/junit5/container/JUnitTestBaseClass.java
Outdated
Show resolved
Hide resolved
...t/java/org/jboss/arquillian/junit5/container/ClassWithArquillianExtensionWithExtensions.java
Show resolved
Hide resolved
junit5/container/src/test/java/org/jboss/arquillian/junit5/container/TestScenarios.java
Show resolved
Hide resolved
…tainer/JUnitJupiterDeploymentAppenderTestCase.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…tainer/JUnitJupiterTestRunnerTestCase.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…tainer/JUnitTestBaseClass.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…tainer/ClassWithArquillianExtensionWithExtensions.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…tainer/TestScenarios.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…tainer/JUnitIntegrationTestCase.java Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
|
@kifj I think you need to force-push, this is not a "real" failure |
bartoszmajsak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging the PR for #301 there is a new issue as described in #309. This could have been avoided if we had (more) tests in the new junit5 module.
With this PR I tried to convert the existing tests for JUnit4 in arquillian-junit-container to arquillian-junit5-container. I'm not sure if they are all useful, and I needed to adapt and delete some. But at least the issue with the lifecycle methods is detected by a test failure, and the fix provided by @lprimak in #310 makes them green again.