-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARQ-1321] Support for HTTPS in URLs injected with @ArquillianResource #43
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8b80765
[ARQ-1321] Support for HTTPS in URLs injected with @ArquillianResource
samaxes f2d8c07
[ARQ-1321] Fixed typo in Javadoc.
samaxes 528cacd
[ARQ-1321] Update servlet URL's protocol to HTTPS when using @Secure …
samaxes a0835c2
Renamed Secure.java to Secured.java and added protocol and port eleme…
samaxes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
test/api/src/main/java/org/jboss/arquillian/test/api/Secured.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* JBoss, Home of Professional Open Source | ||
* Copyright 2013, Red Hat, Inc. and/or its affiliates, and individual | ||
* contributors by the @authors tag. See the copyright.txt in the | ||
* distribution for a full listing of individual contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.jboss.arquillian.test.api; | ||
|
||
import static java.lang.annotation.RetentionPolicy.RUNTIME; | ||
|
||
import java.lang.annotation.Documented; | ||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.Target; | ||
|
||
/** | ||
* Uses the secured protocol for URL and URI injection. | ||
* | ||
* Usage example of field injection:<br /> | ||
* <pre><code> | ||
* @ArquillianResource | ||
* @Secured | ||
* private URL url; | ||
* </code></pre> | ||
* | ||
* @author <a href="http://community.jboss.org/people/silenius">Samuel Santos</a> | ||
* @version $Revision: $ | ||
*/ | ||
@Documented | ||
@Retention(RUNTIME) | ||
@Target({ElementType.FIELD, ElementType.PARAMETER}) | ||
public @interface Secured { | ||
|
||
/** | ||
* Defines the name of the protocol to use. | ||
* | ||
* @return The protocol name or <code>https</code> if the protocol is undefined | ||
*/ | ||
String protocol() default "https"; | ||
|
||
/** | ||
* Defines the port number on the host. | ||
* | ||
* @return The port number or <code>-1</code> if the port is undefined | ||
*/ | ||
int port() default -1; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I think @secure may be more appropriate (without the 'd'). Thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you don't secure it here, you expect to have secured one injected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartoszmajsak you may close this PR, it's super outdated and this has already been implemented here: https://github.com/arquillian/arquillian-showcase/tree/master/extensions/arquillian-smart-url.
However, this should probably be available in the core instead of the showcase project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just wondering what is the status of this, as it looks like a pretty valid functionality. I will look into the extension then. Thanks for your contribution