Add org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec to… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extension/jsf-ftest/pom.xml, in order to build with jdk 9+
|
@WolfgangHG can you pls review? |
WolfgangHG
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
I can confirm that the extension currently does not compile with Java 11 and "maven.compiler.release" = 9.
With your change, it works, and it works also still with Java 1.8.
Aas far as I understand it, you added the JaveEE6 version of the jar that matches "org.jboss.spec:jboss-javaee-6.0:3.0.3.Final".
|
Yes, this is from |
|
@WolfgangHG thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… extension/jsf-ftest/pom.xml, in order to build with jdk 9+