Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix parallel validation errors #1077

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Conversation

dchassin
Copy link
Member

@dchassin dchassin commented Jan 11, 2022

This PR fixes issue #1056

Current issues

Not all modes of failure appear to have been identified. All those found should be documented below in the comments.

Code changes

  • Changed python-requirements target in Makefile.am
  • Removed conflicting requirements

Documentation changes

None

Test and Validation Notes

  • Fixed gldcore/autotest/test_library_include.glm to not use /tmp folder.
  • Fixed gldcore/autotest/test_config*.glm to not use the same test files at the same time.
  • Fixed gldcore/autotest/test_optimize*.glm so they do not share the same object files.
  • Add locking to subcommands that manipulate the shared data folders (template, weather, and library).

@dchassin dchassin changed the title Update test_library_include.glm Fix parallel validation errors Jan 12, 2022
@dchassin dchassin self-assigned this Jan 12, 2022
@dchassin dchassin added the bug Request a fix or change to the code label Jan 12, 2022
@dchassin dchassin added this to the HiPAS 4.2 Final Release milestone Jan 12, 2022
@dchassin dchassin linked an issue Jan 12, 2022 that may be closed by this pull request
@dchassin dchassin marked this pull request as ready for review January 12, 2022 20:27
@aivanova5 aivanova5 merged commit 051d119 into develop Jan 13, 2022
@aivanova5 aivanova5 deleted the develop-fix-parallel-validation branch January 13, 2022 03:01
@dchassin dchassin mentioned this pull request Jan 18, 2022
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Request a fix or change to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel validation can cause intermittent validation errors
2 participants