Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Update house load model #1122

Closed
wants to merge 20 commits into from
Closed

Update house load model #1122

wants to merge 20 commits into from

Conversation

dchassin
Copy link
Member

@dchassin dchassin commented Mar 10, 2022

This PR fixes issue #1121.

Current issues

  1. Snow melt does not work correctly because it cannot calculate the correct rate of snow melt from the snow depth in the weather data.

Code changes

  • Update source/cmdarg.cpp to add support for --loadshape[=CSVFILE] [*|SCHEDULE[,...]] command line option.
  • Change ELCAP1990 to RBSA2014 as default loadshape (about 1/3 the energy use for basic loads).
  • Update module/residential/house_e.{cpp,h} to add support for curtailment and sump pumps.
  • Fix python setup so it doesn't make dist/* unnecessarily.

Documentation changes

Test and Validation Notes

  • Update module/residential/autotest that were affected by change in default loadshapes.
  • Add module/residential/autotest/test_loadshape_dump.glm
  • Add module/residential/autotest/test_sump.glm
  • Add module/residential/autotest/test_curtailment.glm

@dchassin dchassin added the enhancement Request an enhancement or new feature label Mar 10, 2022
@dchassin dchassin added this to the GRIP Final Release milestone Mar 10, 2022
@dchassin dchassin self-assigned this Mar 10, 2022
@dchassin dchassin deleted the develop-update-house-model branch April 15, 2023 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Request an enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant