Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix for single file command unable to produce a viable output file #757

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Fix for single file command unable to produce a viable output file #757

merged 6 commits into from
Sep 28, 2020

Conversation

aivanova5
Copy link
Collaborator

@aivanova5 aivanova5 commented Sep 25, 2020 •
edited by dchassin
Loading

This PR fixes issue #756 .

Current issues

N/A

Code changes

  • Add support for FSO_INITIAL to gldcore/object.cpp:object_saveall().

Documentation changes

N/A

Test and Validation Notes

  • Modify gldcore/autotest/test_json_conversion.glm to detect erroneous GLM save output.

@aivanova5 aivanova5 changed the base branch from master to develop September 25, 2020 18:32
@dchassin
Copy link
Member

Support for FSO_INITIAL has been added to GLM save routine. This could have an adverse affect on routines that currently use this option when saving GLM, even though it was not working correctly.

@dchassin dchassin marked this pull request as ready for review September 28, 2020 13:30
@dchassin dchassin added the bug Request a fix or change to the code label Sep 28, 2020
@dchassin dchassin added this to the HiPAS Final Implementation milestone Sep 28, 2020
@dchassin dchassin linked an issue Sep 28, 2020 that may be closed by this pull request
Single file / JSON converter unable to produce runnable output #756
Closed
@aivanova5 aivanova5 merged commit d32a034 into develop Sep 28, 2020
@aivanova5 aivanova5 deleted the develop-single-file-fix branch September 28, 2020 17:30
@aivanova5 aivanova5 mentioned this pull request Sep 28, 2020
Merged
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dchassin dchassin

Labels
bug Request a fix or change to the code
Projects
None yet
Milestone
HiPAS Patch Release
Development

Successfully merging this pull request may close these issues.

Single file / JSON converter unable to produce runnable output
2 participants
@aivanova5 @dchassin