Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Update object.cpp #777

Merged
merged 7 commits into from
Oct 22, 2020
Merged

Update object.cpp #777

merged 7 commits into from
Oct 22, 2020

Conversation

dchassin
Copy link
Member

@dchassin dchassin commented Oct 7, 2020 •
edited
Loading

This PR fixes issue #769.

Current issues

None

Code changes

  • Add a sync_time != global_clock check in the inner object_sync loop.

Documentation changes

None

Test and Validation Notes

None

@dchassin dchassin added the bug Request a fix or change to the code label Oct 7, 2020
@dchassin dchassin self-assigned this Oct 7, 2020
@dchassin dchassin marked this pull request as ready for review October 8, 2020 16:59
@dchassin dchassin removed the request for review from aivanova5 October 8, 2020 16:59
@dchassin dchassin linked an issue Oct 9, 2020 that may be closed by this pull request
Realtime simulation hangs when recorders use intervals > 1 sec. #769
Closed
@aivanova5 aivanova5 merged commit 4376e34 into develop Oct 22, 2020
@aivanova5 aivanova5 deleted the develop-fix-realtime-lockup branch October 22, 2020 23:13
@aivanova5 aivanova5 restored the develop-fix-realtime-lockup branch October 23, 2020 20:51
aivanova5 added a commit that referenced this pull request Oct 23, 2020
@aivanova5
Revert "Update object.cpp (#777)"
f84093d 
Reverting problematic merge
This reverts commit 4376e34.
@dchassin dchassin mentioned this pull request Oct 26, 2020
Merged
17 tasks
aivanova5 added a commit that referenced this pull request Oct 26, 2020
@aivanova5
Revert "Update object.cpp (#777)"
15d697f 
This reverts commit 4376e34.
Reverting problematic PR
aivanova5 added a commit that referenced this pull request Oct 26, 2020
@aivanova5
Develop fix save conversion (#780)
6da4443 
* Update main.cpp

* Update save.cpp

* Revert "Update object.cpp (#777)"

This reverts commit 4376e34.
Reverting problematic PR

Co-authored-by: Alyona Teyber <Ivanova.alyona5@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mlamlamla mlamlamla Awaiting requested review from mlamlamla

Assignees

@dchassin dchassin

Labels
bug Request a fix or change to the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realtime simulation hangs when recorders use intervals > 1 sec.
2 participants
@dchassin @aivanova5