This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Develop fix stdin polling #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
November 17, 2020 12:29
added 18 commits
December 3, 2020 09:50
aivanova5
approved these changes
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #796.
Current issues
The fix is not great, and there's still an inconsistency in how
gridlabd file.glmandgridlabd file.pywork on Mac and docker linux. But at least the hang is gone. The other side-effect of this "fix" is that running the debugger in python is no longer allowed.Code changes
gldcore/main.cppso no input is allowed on subcommand.Documentation changes
None
Test and Validation Notes
requiresubcommand tests ingldcorenow redirect their output to files.