This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Fix geodata table input #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update version.h * Fix import converter * Delete table2glm_input.glm Co-authored-by: Alyona Teyber <Ivanova.alyona5@gmail.com>
aivanova5
approved these changes
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with
csv-table2glm-objectconverter when using geodata. The correction of these problems is demonstrated with a new geodata tutorial included in this PR.Current issues
There is a known problem with the
gldcore/geodata/powerlines.pypackage. See arras-energy/gridlabd#49 for details.Code changes
gldcore/converters/csv-table2glm-object.py, and other minor functional improvements.gldcore/converters/csv2glm.pyto support-M|--module <MODULE>support.gldcore/converters/json2html.py, add support for hidden objects, fix occasionalobjerror, and add support for object propertiesmap_color,map_weight, andmap_opacity.tutorialfolder togldcore/geodatawith 6 examples of using table to object converter. The notebookgldcore/geodata/docs/Geodata.ipynbis also updated.gldcore/scripts/gridlabd-converterror handling input file types.namefield handling, and nan usage ingldcore/scripts/gridlabd-geodata.Documentation changes
Test and Validation Notes
gldcore/converters/autotest/test_table*.glmto reflect corrected table usage and fix data folder path.gldcore/geodata/tutorialfolders with examples of usage.gldcore/converters/autotest/table2glm_input.csv