Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch console log time format to RFC3339 #538

Merged
merged 1 commit into from
May 8, 2022

Conversation

roman-kruglov
Copy link
Contributor

@roman-kruglov roman-kruglov commented May 8, 2022

instead of default epoch floating time

Description

This format should be more familiar for users. Why not ISO8601 - to my taste RFC3339 is a tad more readable. Although both formats are almost interchangeable.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

It changes the existing console log format, some users might rely on epoch time.

How Has This Been Tested?

Ran in my terminal, saw the output.

Test Configuration

  • Release version: latest main's top (latest release is .33)
  • Platform: Mac OS

Logs

After the change:

2022-05-08T15:56:23+03:00       info    job/http.go:70  single http request     {"target": "https://sample"}
2022-05-08T15:56:23+03:00       info    job/http.go:70  single http request     {"target": "https://sample"}

instead of default epoch floating time
@arriven arriven merged commit f482dd7 into arriven:main May 8, 2022
@roman-kruglov roman-kruglov deleted the change-console-log-time-format branch May 8, 2022 15:52
Copy link

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants