Adjust custom CSS specificity affected by Infima #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
added a commit
that referenced
this pull request
Apr 6, 2023
### Description This PR adds a small section with syndication links to the blog posts listing page. It also removes some `TODO` code that has deemed to be not successful for what we wanted to. Basically, after submitting an issue to one of our library dependencies, I thought that by the uses of the CSS Modules `composes` feature, we could avoid the CSS injection order problem present in: #147 #158 facebook/docusaurus#3678 But it doesn't seem to be the case, so we are in the need of the use of the double selector trick to successfully override some Infima selectors styling with our classes. This closes #153 ### Preview 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make some changes on some selectors' specificity. Due to the way Docusaurus build production styles, this could sometimes create a problem through the CSS injection order, making some Infima styles override custom ones. To overcome this, we are using a subtle trick by duplicating the class in our CSS, to increase the specificity of our selectors.
It doesn't seem like an easy task to solve in general for Docusaurus. More info in: facebook/docusaurus#3678
It also adds proper styling for the Table of Contents on mobile.
This closes #147
Preview