Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise - Align names parameters, arguments and generic types #2987

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

nomisRev
Copy link
Member

No description provided.

Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @nomisRev! I can see how these changes are going to make Raise easier to use in the IDE.

PS: my personal favorite is OtherError, it makes so clear that two different error types are involved there; instead of E and R.

Copy link
Collaborator

@gutiory gutiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @nomisRev !!!

Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev! Code looks more clear with these changes

@nomisRev nomisRev merged commit 6e533fe into main Mar 20, 2023
@nomisRev nomisRev deleted the sv-align-names-raise branch March 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants