Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new module for Arrow Resilience #3006

Merged
merged 11 commits into from
Mar 30, 2023
Merged

Conversation

franciscodr
Copy link
Collaborator

This pull request moves the Arrow Resilience module out from Arrow FX because there are no dependencies between both modules.

As this will be a new module, there is no reason to keep the deprecated methods (already existing in the Arrow FX Coroutines module), so we are removing them in this pull request too.

Additionally, we have changed the type of the resetTimeout and maxResetTimeout parameters to kotlin.time.Duration for the CircuitBreaker class.

@arrow-kt arrow-kt deleted a comment from rafaparadela Mar 30, 2023
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @franciscodr. Looks good to me!

Copy link
Collaborator

@gutiory gutiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@franciscodr franciscodr merged commit 3ec5134 into main Mar 30, 2023
@franciscodr franciscodr deleted the fd-moving-arrow-resilience branch March 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants