Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore properties in sealed hierarchies where the type changes across children #3382

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Ignore properties in sealed hierarchies where the type changes across children #3382

merged 2 commits into from
Feb 28, 2024

Conversation

serras
Copy link
Member

@serras serras commented Feb 28, 2024 •
edited by nomisRev
Loading

Fixes #3380
Fixes #3381

@serras
Fixes #3380
402a0c7 
Ignore properties in sealed hierarchies where the type changes across children
@serras serras requested a review from nomisRev February 28, 2024 09:11
@serras serras self-assigned this Feb 28, 2024
nomisRev
nomisRev approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @serras! Thank you 🙏

@github-actions GitHub Actions
Copy link
Contributor

Kover Report

File Coverage [83.78%]
arrow-libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/info.kt 50.00%
arrow-libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/processor.kt 86.76%
Total Project Coverage 52.89%

@nomisRev nomisRev merged commit 4f4a27c into main Feb 28, 2024
11 checks passed
@nomisRev nomisRev deleted the serras/fix-3380 branch February 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

Assignees

@serras serras

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@serras @nomisRev