Arrow Fx DSL #3443
Arrow Fx DSL #3443
Conversation
|
One DSL to rule them all and in the coroutines bind them? |
|
"It all began with the forging of the Great" DSLs 🤣 |
|
These can also come after 2.0.0 @serras |
| } catch (e: Throwable) { | ||
| throw e | ||
| } | ||
| override fun autoClose(close: (Throwable?) -> Unit) = |
There was a problem hiding this comment.
Nit: I'd like onClose better to reflect onRelease from ResourceScope
| */ | ||
| // TODO should this be implemented on ScopingScope | ||
| // Or should ScopingScope be used to implement a separate SagaScope?? | ||
| public suspend fun <A> ScopingScope.saga( |
There was a problem hiding this comment.
Isn't this just ScopingScope.resource?
| import kotlinx.coroutines.withContext | ||
| import kotlin.coroutines.cancellation.CancellationException | ||
|
|
||
| public interface ScopingScope : AutoCloseScope { |
There was a problem hiding this comment.
This is identical to ResourceScope, no? ScopingScope doesn't feel like a better name IMO.
|
|
||
| public interface ScopingScope : AutoCloseScope { | ||
| public override fun autoClose(close: (Throwable?) -> Unit): Unit | ||
| public fun closing(block: suspend (Throwable?) -> Unit): Unit |
There was a problem hiding this comment.
Similarly, calling this onRelease might make for a more seamless transition.
| import kotlin.coroutines.cancellation.CancellationException | ||
|
|
||
| public interface ScopingScope : AutoCloseScope { | ||
| public override fun autoClose(close: (Throwable?) -> Unit): Unit |
There was a problem hiding this comment.
this can have a default impl of: closing { close(it) }
|
Hey @nomisRev! Turns out I've accidentally reinvented some of your |
This PR proposes a new module for Arrow Fx Coroutines, which covers the existing behavior in Arrow Fx but in a generalised way using DSLs.
parMapNis covered byAwaitAllScopeResourcealready was a DSL,Scopedoffers a similar but more lightweight DSL (noExitCase), and simplified SAM.raceNwill be covered byRacingScope(Upgrading from 1.1.3 til 1.1.4 (and higher) breaks getOrElse: List<String> turns into List<Serializable> #3342)parZipOrAccumulateshould be covered by a combination ofAwaitAllScope& `Accumulating)All the above non-DSL variants, can be implemented by their DSL variations. Simplifying the internals of Arrow Fx Coroutines. The idea behind this is future proofing, since my ambition for 3.0 is to split
Raiseand the typed error handling DSL fromArrow Coresuch that users can rely on only the DSL after 3.0. That should be do-able with only a single binary breakage in Arrow Core, so 3.0 should be source compatible, and 99% binary compatible once Context Parameters are released.AwaitAllScopeparZipOrAccumulateDSLRacingScopeInvestigate if we need, or want,
<E>variants when insideRaise<E>.