add Sinhala locale #1044
Merged
add Sinhala locale #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2168 2208 +40
Branches 345 348 +3
=========================================
+ Hits 2168 2208 +40
Continue to review full report at Codecov.
|
|
@anishnya Just a reminder for you to review the PR when available. Thank you in advance ;) |
Hey, sorry I didn't notice this PR. It looks good to me and I'll merge it in. Thank you for your contribution to Arrow! |
anishnya
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Add Sinhala locale. Sinhala awares time frame format and describe function, takes into account the differences between general, past, and future forms (three different suffixes). So we do not copy the original timeframes dictionary as
timeframes_only_distance, we wrote a newtimeframes_only_distancedictionary :)