Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Spelling 제작년, Remove poorly used expressions #1181

Merged
merged 4 commits into from
Oct 19, 2024

Conversation

yangs1202
Copy link
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

  • The expression '그끄제' is rarely used in Korean expressions. Instead, the expression '3일전' is more natural.
  • I've corrected the spelling. '재작년', not '제작년', is the right expression.

@yangs1202
Copy link
Contributor Author

@jadchaar Hello? Please check this PR.

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangs1202
Copy link
Contributor Author

Hello, @jadchaar
First of all, thank you for making a good open source.

I am using this library very well in Korea,
I'm curious about the next release schedule.

Recently, I think you merged something similar with the master.
I'm sorry if it's rude.

Then I'll wait for your reply. Have a good day.

@jadchaar jadchaar merged commit cbe4949 into arrow-py:master Oct 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants