-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.0.0 and update CHANGELOG #924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1896 1896
Branches 311 311
=========================================
Hits 1896 1896
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's finally happening! Looks good to me.
🚀🎉🎉🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nitpick from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments!
Hey guys I will make the suggested changes then get this ready for review. Do you think we should just link to the migration guide for breaking changes or do they need to be in the changelog as well? |
I think just linking an being explicit about the migration guide outlining the breaking changes is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ship it! 🚀🚀🚀🚀🚀🚀
Let's ship it! 💎 🚀 🚀 🚀 🚀 Feeling excited! |
There's no tag on GitHub and no release on PyPI. Is this on purpose? Just wondering :) |
Haha no, one of us needs to push the button to publish. Should be coming today when I finish work. |
@michael-k and it's released! 🥳 |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Still a WIP