Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.0.0 and update CHANGELOG #924

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

systemcatch
Copy link
Collaborator

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Still a WIP

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #924 (7a4c9cd) into master (f15a7ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1896      1896           
  Branches       311       311           
=========================================
  Hits          1896      1896           
Impacted Files Coverage Δ
arrow/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15a7ae...ae67704. Read the comment docs.

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's finally happening! Looks good to me.

🚀🎉🎉🎉

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick from my side.

CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments!

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Show resolved Hide resolved
arrow/_version.py Show resolved Hide resolved
@systemcatch
Copy link
Collaborator Author

Hey guys I will make the suggested changes then get this ready for review. Do you think we should just link to the migration guide for breaking changes or do they need to be in the changelog as well?

@jadchaar
Copy link
Member

Hey guys I will make the suggested changes then get this ready for review. Do you think we should just link to the migration guide for breaking changes or do they need to be in the changelog as well?

I think just linking an being explicit about the migration guide outlining the breaking changes is sufficient.

@systemcatch systemcatch marked this pull request as ready for review February 24, 2021 20:30
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it! 🚀🚀🚀🚀🚀🚀

@krisfremen
Copy link
Member

Let's ship it! 💎 🚀 🚀 🚀 🚀

Feeling excited!

@systemcatch systemcatch merged commit 5248407 into master Feb 25, 2021
@michael-k
Copy link
Contributor

There's no tag on GitHub and no release on PyPI. Is this on purpose? Just wondering :)

@systemcatch
Copy link
Collaborator Author

There's no tag on GitHub and no release on PyPI. Is this on purpose? Just wondering :)

Haha no, one of us needs to push the button to publish. Should be coming today when I finish work.

@systemcatch
Copy link
Collaborator Author

@michael-k and it's released! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants