Add new http_component that would return the body of the response and custom error messages. #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pri1012
changed the title
ylecuyer
reviewed
May 1, 2024
ylecuyer
reviewed
May 1, 2024
ylecuyer
reviewed
May 1, 2024
ylecuyer
reviewed
May 1, 2024
ylecuyer
reviewed
May 1, 2024
saikambaiyyagari
force-pushed
the
vvaradarjan/new_http_component
branch
from
bf514d6 to
d9cd078
Compare
saikambaiyyagari
force-pushed
the
vvaradarjan/new_http_component
branch
from
d9cd078 to
f93bddf
Compare
saikambaiyyagari
force-pushed
the
vvaradarjan/new_http_component
branch
from
f93bddf to
96e7cf9
Compare
|
nudge, pt deux... is there anything I can do to help move this along? I believe this PR is the last thing standing in between us and getting off an old fork that is holding back our ability to upgrade faraday (among other things). |
codealchemy
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes changes which will help use the latest koala version when http_component is set
Changes included:
Parsing of response: when http_component is set, we receive Koala::Http_service response instead of a hash and generate_results method handles only JSON response. This affects all batch request.
Custom Error message when the body is nil