Windows Performance Improvement & Multi-Item support #43
Conversation
- Try using IFileOperation instead of SHFileOperation - Use pywin32 to accomplish this - Implement fallback when pywin32 not available - Handles paths like `C:\` just fine bu the `\\?\` paths in the test cause issue - Add batching for IFileOperation version (performance) - Minor formatting applied by editor
- Strip these characters off if present just like old implementation
- Add check for windows version for IFileOperation - Add list support to legacy version - Remove some debugging code - Fix bug in path converson Not sure if there is a better way to layout this file
Formatter also ran on these so some other minor changes.
|
Wow this is quite a PR 💪 :) Do you mind adding a test on Windows to force using the legacy implementation to be sure it is still tested? |
|
Yeah it would be possible to try forcing the different versions, right now I am not sure which version the CI is actually testing, it looks like it is most likely still testing the legacy version, I'll see about getting the CI to install pywin32 and then test both versions. |
|
FTR the CI is using Windows Server 2019, so it will likely test the new implementation only. |
|
Either way, I should be able to get it to run both, with the dependency on pywin32 even though it is a new enough version of the OS it will not run without that package installed. I don't think the chocolatey python package includes anything different than the standard windows python installers, if that is the case it should be testing the legacy version based on what I have seen on Windows 10. |
|
@arsenetar this looks great and it's been a long time since these issues should have been tackled. You tackle them and it's excellent news. As the README says, I'm looking for someone to take over this library. You're already doing a good job with dupeguru, would you mind taking this library too? |
|
@hsoft I don't have any issues with taking this library over. |
|
Good! IIRC, we had problems during the last transfer because you had to delete your fork first. So I'll merge your PR right now and then let you delete your fork before proceeding. Do you have a PyPI account? I'll transfer you publishing rights too. |
ghost
merged commit
|
I have remove my fork. I did not have a PyPI account, I do now username is the same as here |
|
Transfer initiated. You've also been added as an owner of the pypi package. |
|
Looks like both are good now. |
|
Good, godspeed! :) |
Notes: