Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up the dependency #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump up the dependency #10

wants to merge 1 commit into from

Conversation

tk42
Copy link

@tk42 tk42 commented Nov 24, 2022

Problem

Can't init by running go run github.com/arsmn/fastgql init

# github.com/arsmn/fastgql/graphql/executor
../../../../go/pkg/mod/github.com/arsmn/fastgql@v0.14.0/graphql/executor/executor.go:73:22: cannot use validator.VariableValues(e.es.Schema(), rc.Operation, params.Variables) (value of type error) as type *gqlerror.Error in assignment:
        need type assertion
../../../../go/pkg/mod/github.com/arsmn/fastgql@v0.14.0/graphql/executor/executor.go:174:15: cannot use err (variable of type error) as type *gqlerror.Error in argument to errcode.Set:
        need type assertion
../../../../go/pkg/mod/github.com/arsmn/fastgql@v0.14.0/graphql/executor/executor.go:175:29: cannot use err (variable of type error) as type *gqlerror.Error in array or slice literal:
        need type assertion

Reason

gqlparser wouldn’t return *gqlerror.Error anymore. It just return error. See here if you interested.

What did I fixed

As workaround, Message of gqlerror.Error is set to error.

And this is irrelevant but golang-lru supports Generics now. So types could be specified. ⭐

@OysteinAndersenBilles
Copy link

I really need this.

@gaby
Copy link

gaby commented Jun 12, 2023

@arsmn Is this project still alive? Currently there's no way to install/use it

@arsmn
Copy link
Owner

arsmn commented Jun 12, 2023

@gaby
This project is not maintained for a long time as I didn't have free time to work on.
I will take a look at to improve and update it soon.

@gaby
Copy link

gaby commented Jun 12, 2023

@arsmn Thanks! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants