Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trims 6 more characters off front of input. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dylan-stark
Copy link

When I tried running the script I got a somewhat cryptic error message: syntax error (invalid integer constant (error token is "16#")). When I looked into it, the root issue was that INPUT still had a leading <pre> after the trimming on lines 370–372. This patch takes off an extra 6 characters to remove the <pre> . Everything seems to be working fine after that.

@rjpcasalino
Copy link

rjpcasalino commented Apr 18, 2023

Nice, that worked for me. Thanks @dylan-stark. For curious folks, I ran this on nixos 22.11.20230219.0cf4274 (Raccoon) just using xterm

@almereyda
Copy link

almereyda commented Aug 15, 2024

When applying this patch in #9, I am now sometimes getting errors, such as:

/usr/src/app/./aic.sh: line 445: 16#style: value too great for base (error token is "16#style")
/usr/src/app/./aic.sh: line 453: 16#: invalid integer constant (error token is "16#")

Sometimes no image will appear.

Before the path, line 445 errored with:

/usr/src/app/./aic.sh: line 445: 16#: invalid integer constant (error token is "16#")

@nikhiltri
Copy link
Member

Thanks for this PR! We'll take a look in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants