Advances tour stop when it's audio playback ends (AIC-555) #317
Conversation
sam33rdhakal
commented
Oct 30, 2018
sam33rdhakal
commented
- Advances tour stop when selected stop's audio translation playback ends.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -362,7 +367,7 @@ class AudioPlayerService : DaggerService(), PlayerService { | |||
| } | |||
| } | |||
|
|
|||
| fun setArticObject(_articObject: Playable, audio: AudioFileModel, resetPosition: Boolean = false) { | |||
| fun changeAudio(_articObject: Playable, audio: AudioFileModel, resetPosition: Boolean = false) { | |||
There was a problem hiding this comment.
Method changeAudio has 28 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -23,4 +27,57 @@ class TourProgressManager { | |||
| val selectedTour: Subject<Optional<ArticTour>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val proposedTour: Subject<Optional<Pair<ArticTour, ArticTour.TourStop>>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val leaveTourRequest: Subject<Boolean> = PublishSubject.create() | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Method playBackEnded has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
| @@ -23,4 +27,57 @@ class TourProgressManager { | |||
| val selectedTour: Subject<Optional<ArticTour>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val proposedTour: Subject<Optional<Pair<ArticTour, ArticTour.TourStop>>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val leaveTourRequest: Subject<Boolean> = PublishSubject.create() | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Method playBackEnded has 28 lines of code (exceeds 25 allowed). Consider refactoring.
| * this method advances [selectedStop] to next tour stop. | ||
| */ | ||
| @SuppressLint("CheckResult") | ||
| fun playBackEnded(audioFileModel: AudioFileModel) { |
There was a problem hiding this comment.
Please add a @WorkerThread annotation to make it clear this shouldn't run on the main thread.
There was a problem hiding this comment.
Good idea. Updated.
tour_manager/src/main/java/edu/artic/tours/manager/TourProgressManager.kt
Show resolved
Hide resolved
| audioFileDao | ||
| .getAudioByIdAsync(audioID) | ||
| .toObservable() | ||
| .subscribe { audioFile -> |
There was a problem hiding this comment.
Please add a simple onError to this subscription, on the off chance that audioID is malformed. Something that does nothing in production but uses Timber in debug, perhaps?
…on playback completes
…udio playback completion (AIC-555)
sam33rdhakal
force-pushed
the
tour_advance
branch
from
29da650 to
43a385f
Compare
| @@ -23,4 +30,61 @@ class TourProgressManager { | |||
| val selectedTour: Subject<Optional<ArticTour>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val proposedTour: Subject<Optional<Pair<ArticTour, ArticTour.TourStop>>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val leaveTourRequest: Subject<Boolean> = PublishSubject.create() | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Method playBackEnded has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
| @@ -23,4 +30,61 @@ class TourProgressManager { | |||
| val selectedTour: Subject<Optional<ArticTour>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val proposedTour: Subject<Optional<Pair<ArticTour, ArticTour.TourStop>>> = BehaviorSubject.createDefault(Optional(null)) | |||
| val leaveTourRequest: Subject<Boolean> = PublishSubject.create() | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Method playBackEnded has 32 lines of code (exceeds 25 allowed). Consider refactoring.
