Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing document with unset fields defaults #28

Merged
merged 6 commits into from
Nov 9, 2020

Conversation

art049
Copy link
Owner

@art049 art049 commented Oct 26, 2020

Fixes #13

  • Comprehensive exception with key names
  • Documentation

@art049 art049 linked an issue Oct 26, 2020 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 26, 2020

🚀 Deployed on https://docs-preview-28--odmantic.netlify.app

@art049 art049 force-pushed the master branch 13 times, most recently from 81c917d to 3cba9a3 Compare October 27, 2020 00:37
@art049 art049 force-pushed the fix/document-with-unset-fields branch 2 times, most recently from 6f3ebc2 to aef847d Compare October 27, 2020 01:12
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #28 (33d4de1) into master (f72ae95) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          827       882   +55     
  Branches       135       143    +8     
=========================================
+ Hits           827       882   +55     
Flag Coverage Δ
tests-3.6-4 99.08% <100.00%> (+0.06%) ⬆️
tests-3.6-4.2 99.08% <100.00%> (+0.06%) ⬆️
tests-3.6-4.4 99.08% <100.00%> (+0.06%) ⬆️
tests-3.7-4 98.51% <100.00%> (+0.09%) ⬆️
tests-3.7-4.2 98.51% <100.00%> (+0.09%) ⬆️
tests-3.7-4.4 98.51% <100.00%> (+0.09%) ⬆️
tests-3.8-4 98.29% <100.00%> (+0.11%) ⬆️
tests-3.8-4.2 98.29% <100.00%> (+0.11%) ⬆️
tests-3.8-4.4 98.29% <100.00%> (+0.11%) ⬆️
tests-3.9-4 98.18% <100.00%> (+0.12%) ⬆️
tests-3.9-4.2 98.18% <100.00%> (+0.12%) ⬆️
tests-3.9-4.4 98.18% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/config.py 100.00% <100.00%> (ø)
odmantic/engine.py 100.00% <100.00%> (ø)
odmantic/exceptions.py 100.00% <100.00%> (ø)
odmantic/field.py 100.00% <100.00%> (ø)
odmantic/model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72ae95...33d4de1. Read the comment docs.

@art049 art049 changed the title Allow to parsing document with unset fields using default values Allow parsing document with unset fields using default values Oct 27, 2020
@art049 art049 changed the title Allow parsing document with unset fields using default values Allow parsing document with unset fields having default values Oct 27, 2020
@art049 art049 force-pushed the fix/document-with-unset-fields branch from bf14368 to 3f25120 Compare November 8, 2020 14:21
@art049 art049 force-pushed the fix/document-with-unset-fields branch from 8016e89 to 33d4de1 Compare November 9, 2020 00:20
@art049 art049 changed the title Allow parsing document with unset fields having default values Allow parsing document with unset fields using default values Nov 9, 2020
@art049 art049 changed the title Allow parsing document with unset fields using default values Allow parsing document with unset fields defaults Nov 9, 2020
@art049 art049 merged commit 98058e1 into master Nov 9, 2020
@art049 art049 deleted the fix/document-with-unset-fields branch November 9, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when reading documents with unset fields
2 participants