Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Config class to configure models #37

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Use a Config class to configure models #37

merged 2 commits into from
Nov 8, 2020

Conversation

art049
Copy link
Owner

@art049 art049 commented Nov 4, 2020

Fixes #7

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

🚀 Deployed on https://docs-preview-37--odmantic.netlify.app

@art049 art049 force-pushed the config-class branch 3 times, most recently from 17f0f0d to 9c60cc2 Compare November 8, 2020 02:32
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #37 (2d7266b) into master (e381c4d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        12    +2     
  Lines          788       823   +35     
  Branches       129       135    +6     
=========================================
+ Hits           788       823   +35     
Flag Coverage Δ
tests-3.6-4 99.01% <100.00%> (+0.04%) ⬆️
tests-3.6-4.2 99.01% <100.00%> (+0.04%) ⬆️
tests-3.6-4.4 99.01% <100.00%> (+0.04%) ⬆️
tests-3.7-4 98.40% <100.00%> (+0.07%) ⬆️
tests-3.7-4.2 98.40% <100.00%> (+0.07%) ⬆️
tests-3.7-4.4 98.40% <100.00%> (+0.07%) ⬆️
tests-3.8-4 98.17% <100.00%> (+0.08%) ⬆️
tests-3.8-4.2 98.17% <100.00%> (+0.08%) ⬆️
tests-3.8-4.4 98.17% <100.00%> (+0.08%) ⬆️
tests-3.9-4 98.05% <100.00%> (+0.08%) ⬆️
tests-3.9-4.2 98.05% <100.00%> (+0.08%) ⬆️
tests-3.9-4.4 98.05% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/config.py 100.00% <100.00%> (ø)
odmantic/model.py 100.00% <100.00%> (ø)
odmantic/typing.py 100.00% <100.00%> (ø)
odmantic/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e381c4d...2d7266b. Read the comment docs.

@art049 art049 changed the title Use Config subclass to configure models Use a Config class to configure models Nov 8, 2020
@art049 art049 merged commit 740f537 into master Nov 8, 2020
@art049 art049 deleted the config-class branch November 8, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add custom encoder for ipv4
1 participant