Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modified mark clearing on save for nested models #88

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix modified mark clearing on save for nested models #88

merged 1 commit into from
Mar 4, 2021

Conversation

Olegt0rr
Copy link
Contributor

__fields_modified__ cleared also for embedded models on save

Fixes #87

`__fields_modified__` cleared also for embedded models on save
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #88 (7133813) into master (541d411) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          883       883           
  Branches       143       143           
=========================================
  Hits           883       883           
Flag Coverage Δ
tests-3.6-4 99.08% <100.00%> (ø)
tests-3.6-4.2 99.08% <100.00%> (ø)
tests-3.6-4.4 99.08% <100.00%> (ø)
tests-3.7-4 98.51% <100.00%> (ø)
tests-3.7-4.2 98.51% <100.00%> (ø)
tests-3.7-4.4 98.51% <100.00%> (ø)
tests-3.8-4 98.30% <100.00%> (ø)
tests-3.8-4.2 98.30% <100.00%> (ø)
tests-3.8-4.4 98.30% <100.00%> (ø)
tests-3.9-4 98.18% <100.00%> (ø)
tests-3.9-4.2 98.18% <100.00%> (ø)
tests-3.9-4.4 98.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541d411...7133813. Read the comment docs.

@art049 art049 changed the title modified mark cleared also for embedded models Fix modified mark clearing on save for nested models Mar 4, 2021
@art049
Copy link
Owner

art049 commented Mar 4, 2021

Thanks @Olegt0rr !

@art049 art049 merged commit 4a28a3e into art049:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modified mark is not cleared for embedded models on save
2 participants